Fix double-emitting of JSX text that looks like comments#62033
Closed
RyanCavanaugh wants to merge 3 commits intomicrosoft:mainfrom
Closed
Fix double-emitting of JSX text that looks like comments#62033RyanCavanaugh wants to merge 3 commits intomicrosoft:mainfrom
RyanCavanaugh wants to merge 3 commits intomicrosoft:mainfrom
Conversation
typescript-bot
added
Author: Team
For Milestone Bug
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug related to double-emitting of JSX text that looks like comments in TypeScript compilation. The fix specifically addresses issue #61860 by modifying the comment emission logic in the emitter to properly handle JSX-related nodes.
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/cases/compiler/jsxCommentEmit.ts | Adds test cases for JSX comment emission with various scenarios including text that resembles comments |
| tests/baselines/reference/ (multiple files) | Expected output baselines for the new test cases across different JSX and comment removal configurations |
| src/compiler/emitter.ts | Updates comment emission logic by replacing simple JSX text checks with more comprehensive JSX node type validation |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #61860